bbPress ShowcasebbPress Showcase

bbPress Showcase » bbPress Chat

1. Gautam
   

   junior member
   Joined: Jul '09
   Posts: 6

   offline

   Reputation:8

    

   Can you post a patch for these 2 tickets or should we move them forward?:
   

   1. http://trac.bbpress.org/ticket/1182
   2. http://trac.bbpress.org/ticket/1183
   
   

   - Gautam ( http://www.gaut.am )

   Posted 1 year ago #
2. _ck_
   

   senior admin
   Joined: Jul '06
   Posts: 884

   offline

   Reputation:949

    

   Unfortunately they don't really matter anymore as it would require going back to change plugins to optimize them, which is highly unlikely to ever happen now.

   The first one is not too hard to fix though.

   My best guess would be in functions.bb-core.php

   line 992
   return new BB_Query( 'topic', $query_args, "bb_view_$view" );

   should become

   return empty($query_args) ? false : (new BB_Query( 'topic', $query_args, "bb_view_$view" );

   In theory that should prevent a wasted query when the query is empty.

   Completely untested though and nothing right now would take advantage of it.

   Posted 1 year ago #

RSS feed for this topic