bbPress ShowcasebbPress Showcase

bbPress Showcase » Plugins by Others

1. citizenkeith
   

   member
   Joined: May '08
   Posts: 14

   offline

   Reputation:16

    

   I have posted this over at the bbPress forums, but nobody (not even the original author) has responded.

   I'm using bbPress 0.9.0.6 and the latest version of bbVideo.

   If I quote a post that contains a video, I have to add an extra carriage return after the ending blockquote tag, or else my post ends up in the quoted area.

   I suppose this could also be a problem with the quote plugin, but it only happens when quoting a post that contains a video.

   Any ideas?

   Posted 2 years ago #
2. _ck_
   

   senior admin
   Joined: Jul '06
   Posts: 900

   offline

   Reputation:1,020

    

   It happens because the pattern they are using is what we call "greedy" in regex. It keeps going until it hits a newline.

   Are the video links on their own clear line with nothing else after them on the same line? The quote plugin probably adds the blockquote on the same line. They are using a very bad pattern to match links in their plugin.

   you might have to do some trial and error

   I need to know which quote plugin you are using.
   There will be an add_filter for post_text in there, which I need to know what it says. We may have to increase or decrease it's priority.

   alternately try editing bbvideo.php
   line 169 AND line 177
   change the |i to |iU
   but by itself that won't be enough.

   If all that fails, we have to change the patterns in the provider.inc.php
   Does it happen for only certain providers? Or everyone, including youtube?

   Posted 2 years ago #
3. _ck_
   

   senior admin
   Joined: Jul '06
   Posts: 900

   offline

   Reputation:1,020

    

   Oh wait, the quote plugin works by just adding the blockquote tag.

   Are you also using bbcode ie. [ /quote ]

   Show me a sample of what an edited message with a quote and a video link looks like.

   Posted 2 years ago #
4. citizenkeith
   

   member
   Joined: May '08
   Posts: 14

   offline

   Reputation:16

    

   _ck_ - 2 hours ago  » 
   Oh wait, the quote plugin works by just adding the blockquote tag.
   Are you also using bbcode ie. [ /quote ]
   Show me a sample of what an edited message with a quote and a video link looks like.

   Here's a recent message with a quote and video link:

   <blockquote><cite>Keith - 4 minutes ago <a href="http://www.xxxxxxx.com/forum/topic.php?id=631&page=18#post-76526">&nbsp;&raquo;&nbsp;</a></cite>
   http://www.youtube.com/watch?v=d7mflplo6x8
   
   </blockquote>
   Great song!  I'll be on the lookout for his albums.

   Posted 2 years ago #
5. citizenkeith
   

   member
   Joined: May '08
   Posts: 14

   offline

   Reputation:16

    

   _ck_ - 2 hours ago  » 
   I need to know which quote plugin you are using.

   I'm using "0.2mod" which I think is a version you posted at bbpress.org.

   There will be an add_filter for post_text in there, which I need to know what it says.

   function fel_addcitetag( $tags ) { $tags['cite'] = array();	return( $tags );}
   add_filter( 'bb_allowed_tags', 'fel_addcitetag' );

   Let me know if you need anything else...

   Posted 2 years ago #
6. _ck_
   

   senior admin
   Joined: Jul '06
   Posts: 900

   offline

   Reputation:1,020

    

   The example you posted is the one that works? or doesn't work correctly?

   Posted 2 years ago #
7. citizenkeith
   

   member
   Joined: May '08
   Posts: 14

   offline

   Reputation:16

    

   That one does not work correctly. It will work with another carriage return after the blockquote.

   Also, I think it doesn't for all video providers, not just YouTube.

   Posted 2 years ago #
8. _ck_
   

   senior admin
   Joined: Jul '06
   Posts: 900

   offline

   Reputation:1,020

    

   Do you know how do a selective view source on just that post in Firefox? I need to see the true code it generates, otherwise this is going to just be a bunch of guessing.

   Either that or give me a link to an actual example.

   Posted 2 years ago #
9. citizenkeith
   

   member
   Joined: May '08
   Posts: 14

   offline

   Reputation:16

    

   I tried posting the code here, but the post was too large. Can you contact me via email and I'll send you the code? Or just give you a login. It's a private forum, so I don't want to post links here.

   Posted 2 years ago #
10. _ck_
    

    senior admin
    Joined: Jul '06
    Posts: 900

    offline

    Reputation:1,020

     

    I need just the portion for that post, not the entire page.

    This is an example of what I need

    <div class="post"><blockquote><p><cite>_ck_ - 2 hours ago <a href="/forums/topic/bbvideo-bug#post-1864" rel="nofollow" target="_blank">&nbsp;»&nbsp;</a></cite><br />
    Oh wait, the quote plugin works by just adding the blockquote tag.<br />
    Are you also using bbcode ie.  <code>[ /quote ]</code><br />
    Show me a sample of what an edited message with a quote and a video link looks like.
    </p></blockquote>
    <p>Here's a recent message with a quote and video link:</p>
    <pre><code><blockquote><cite>Keith - 4 minutes ago <a href="http://www.xxxxxxx.com/forum/topic.php?id=631&page=18#post-76526">&nbsp;&raquo;&nbsp;</a></cite>
    
    <a href="http://www.youtube.com/watch?v=d7mflplo6x8" rel="nofollow" target="_blank">http://www.youtube.com/watch?v=d7mflplo6x8</a>
    
    </blockquote>
    Great song!  I'll be on the lookout for his albums.</code></pre>
    <div class="bb_attachments"></div>
    		<div class="poststuff" style="clear: both;">
    			Posted <span class="timetitle" title="Tue, 22 Jun 2010 16:39:53 -0400">12 hours ago</span>
    			<a href="#post-1865">#</a>

    Posted 2 years ago #

RSS feed for this topic