bbPress ShowcasebbPress Showcase

bbPress Showcase » Plugins by _ck_

11. Wyvn
    

    junior member
    Joined: Feb '08
    Posts: 5

    offline

    Reputation:6

     

    Once the forum goes live I can let you see it. I add the poll, I get this error on the next page. Nothing else is in the top as you can see. Poll seems to work fine afterwards.

    PHP version is 5.2.5

    Warning: Missing argument 1 for bb_polls_save_poll_setup(), called in
    /home/xxxx/public_html/forum/my-plugins/bbpress-polls/bb-polls.php on line 338 and defined in /home/xxxx/public_html/forum/my-plugins/bbpress-polls/bb-polls.php on line 285

    Warning: Cannot modify header information - headers already sent by (output started at /home/xxxx/public_html/forum/my-plugins/bbpress-polls/bb-polls.php:285) in /home/xxxx/public_html/forum/bb-includes/pluggable.php on line 164

    Posted 2 years ago #
12. _ck_
    

    senior admin
    Joined: Jul '06
    Posts: 732

    offline

    Reputation:783

     

    Ah, the headers_already_sent error is being caused by the 1st error.

    I will have to investigate that 1st error, thanks for reporting!

    UPDATE: I found the bug, it's very simple, just a subtle typo.

    I will post 0.33 onto bbpress.org shortly.

    This is a demo of the bbPress Signatures plugin!
    If you use my plugins, please considering donating to help continue their development.

    Posted 2 years ago #
13. Wyvn
    

    junior member
    Joined: Feb '08
    Posts: 5

    offline

    Reputation:6

     

    Works good, thanks.

    Posted 2 years ago #
14. zmaroti
    

    new member
    Joined: Mar '08
    Posts: 2

    offline

    Reputation:2

     

    Hi,

    Is there any respiratory of yours where I could access version 0.50? I downloaded 0.50 and modified it at a lot of places. Then just yesterday you sent out 0.51.

    I was W3C validating my bbPress pages and found a ton of errors, I fixed most allready but after activating bbpolls I got new ones. Thus I started to rewrite parts of your code. While I was doing so, I pretty much reformatted the code for better view so diffing my version would be a pain now to 0.51. A diff between 0.50 and 0.51 for me would help a lot to port your changes into my version.

    As an admin you can check my email. I'd be grateful if you could send me the diff or older version in email.

    ps: I'd also send back some of the code and I have also some other questions which is probably not for this topic.

    With best regards,
    Zoltán Maróti

    Posted 2 years ago #
15. _ck_
    

    senior admin
    Joined: Jul '06
    Posts: 732

    offline

    Reputation:783

     

    Typically I don't give a darn about validation but if it's something easy to fix, I'm happy to put it in there.

    Validation is just a syntax check - all browsers will support old methods for many years to come - perhaps decades.

    You can use the SVN or TRAC to see the differences between 0.50 and 0.51
    http://plugins-dev.bbpress.org/changeset?new=bbpress-polls%40937&old=bbpress-polls%40922
    http://plugins-dev.bbpress.org/log/bbpress-polls/

    0.51 was just activation of some code I hid to reduce the admin menu (which turned out to be a bad idea for our international friends) and a code typo bug-fix where I forgot to close a tag.

    If you'd like to contact me I can often be found on the bbpress irc channel at irc://irc.freenode.net#bbpress

    Posted 2 years ago #
16. zmaroti
    

    new member
    Joined: Mar '08
    Posts: 2

    offline

    Reputation:2

     

    Thank you very much for feedback. I validate the pages because a well formatted page will use less resources on the client side, and hopefully will work together with new browsers better if you implements the standards.

    I've made a diff which is pretty much just cosmetic right now (mostly missing "-s and at function bb_press_show_vote_result a missing space plus wrong order or closing <p> and <div> tags.

    You can find it here:
    http://atp.pedia.szote.u-szeged.hu/~xavier/bb-poll_diff.txt

    I will try to catch you on irc for the rest of things I have in my mind (forexample bb_polls_pre_poll() is a bit messy)

    Regards,
    Zoltán

    Posted 2 years ago #
17. _ck_
    

    senior admin
    Joined: Jul '06
    Posts: 732

    offline

    Reputation:783

     

    Ah I see mostly you don't like how I am lazy about putting tag attributes in quotes.
    It's definitely a bad habit, I admit.

    Posted 2 years ago #
18. jonny
    

    new member
    Joined: Nov '07
    Posts: 3

    offline

    Reputation:3

     

    I would see it as a big improvement if bbPress Polls produces valid code. It would be great if zmarotis changes could improve the next release in this direction.

    Posted 2 years ago #
19. _ck_
    

    senior admin
    Joined: Jul '06
    Posts: 732

    offline

    Reputation:783

     

    Jonny, you should already see the new xhtml code in the newest release (0.5.4)
    http://bbpress.org/plugins/topic/bbpress-polls/

    I've also added some improvements to minimize the amount of javascript used when "ajax-like" mode is enabled.

    Posted 2 years ago #
20. Brian
    

    new member
    Joined: Mar '08
    Posts: 2

    offline

    Reputation:2

     

    Hey CK
    I'm trying to work your polls plug. Works great as an admin. But members are not allowed to create a poll.?
    Thanks Brian

    http://www.willowcreeksports.com/forums/

    polls version 0.5.4
    bbpress 0.8.3.1

    Posted 2 years ago #

RSS feed for this topic